Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658325
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 |
| Date | 2017-06-06 05:10 +0200 |
| Message-ID | <tPd2y-3dl-5@gated-at.bofh.it> (permalink) |
| References | <tMp0d-6bg-3@gated-at.bofh.it> <tMp0g-6bg-59@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2017-05-29 18:15 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
> The thermal monitor is included in sysctrl.
>
> Furthermore, since SoC installed in the reference board doesn't have a
> calibrated value of thermal monitor, this patch gives the default value
> for LD20 Reference board via device-tree property.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts | 25 ++++++++++++++++++++++
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 6 ++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> index 609162a..79e1363 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> @@ -73,6 +73,27 @@
> i2c4 = &i2c4;
> i2c5 = &i2c5;
> };
> +
> + thermal-zones {
> + cpu_thermal {
> + polling-delay-passive = <250>; /* 250ms */
> + polling-delay = <1000>; /* 1000ms */
> + thermal-sensors = <&pvtctl>;
> +
> + trips {
> + cpu_crit: cpu_crit {
> + temperature = <95000>; /* 95C */
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + cpu_alert: cpu_alert {
> + temperature = <85000>; /* 85C */
> + hysteresis = <2000>;
> + type = "passive";
> + };
> + };
> + };
> + };
> };
>
> ðsc {
> @@ -86,3 +107,7 @@
> &i2c0 {
> status = "okay";
> };
> +
> +&pvtctl {
> + socionext,tmod-calibration = <0x0f22 0x68ee>;
> +};
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> index a6b3a70..effa2e3 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> @@ -417,6 +417,12 @@
> compatible = "socionext,uniphier-ld20-reset";
> #reset-cells = <1>;
> };
> +
> + pvtctl: pvtctl {
> + compatible = "socionext,uniphier-ld20-thermal";
> + interrupts = <0 3 1>;
> + #thermal-sensor-cells = <0>;
> + };
The 3rd cell of the interrupts is 1.
So, you mean the interrupt is edge-triggered.
(Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt)
However, in your driver code, the interrupt is explicitly cleared in
the IRQ handler.
I checked the SoC implementation document and
the PVT IRQ seems to be level-triggered.
--
Best Regards
Masahiro Yamada
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] add UniPhier thermal support Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
[PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Rob Herring <robh@kernel.org> - 2017-06-05 19:30 +0200
Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-06 04:50 +0200
[PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Keerthy <j-keerthy@ti.com> - 2017-05-29 12:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 04:50 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Keerthy <j-keerthy@ti.com> - 2017-05-30 05:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 06:10 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Eduardo Valentin <edubezval@gmail.com> - 2017-05-29 18:50 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 11:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-05 10:50 +0200
[PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-06 05:10 +0200
[PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Eduardo Valentin <edubezval@gmail.com> - 2017-05-29 18:40 +0200
Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 11:30 +0200
csiph-web