Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658319
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor |
| Date | 2017-06-06 04:50 +0200 |
| Message-ID | <tPcJc-2P3-7@gated-at.bofh.it> (permalink) |
| References | <tMp0d-6bg-3@gated-at.bofh.it> <tMp0e-6bg-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2017-05-29 18:15 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> Add devicetree binding documentation for thermal monitor implemented on
> Socionext UniPhier SoCs.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
> new file mode 100644
> index 0000000..72834e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
> @@ -0,0 +1,54 @@
> +* UniPhier Thermal bindings
> +
> +This describes the devicetree bindings for thermal monitor supported by
> +PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext
> +UniPhier SoCs.
This paragraph implies this might be a HWMON driver if more features
are implemented,
but I assume you use only the Temperature part for a thermal driver at
the moment.
(I do not know if other sensors are useful or not, so I do not mind it much.)
> +Required properties:
> +- compatible :
> + - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC
> + - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC
> +- reg : Offset address of the thermal registers from sysctrl
This "reg" does not exist in the example.
Your driver code uses regmap for register access.
> +- interrupts : IRQ for the temperature alarm
> +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details.
> +
> +Optional properties:
> +- socionext,tmod-calibration: A pair of calibrated values referred from PVT,
> + in case that the values aren't set on SoC,
> + like a reference board.
> +
> +Example:
> +
> + sysctrl@61840000 {
> + compatible = "socionext,uniphier-ld20-sysctrl",
> + "simple-mfd", "syscon";
> + reg = <0x61840000 0x10000>;
> + ...
> + pvtctl: pvtctl {
> + compatible = "socionext,uniphier-ld20-thermal";
> + interrupts = <0 3 1>;
> + #thermal-sensor-cells = <0>;
> + };
> + ...
> + };
> +
> + thermal-zones {
> + cpu_thermal {
> + polling-delay-passive = <250>; /* 250ms */
> + polling-delay = <1000>; /* 1000ms */
> + thermal-sensors = <&pvtctl>;
> +
> + trips {
> + cpu_crit: cpu_crit {
> + temperature = <95000>; /* 95C */
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + cpu_alert: cpu_alert {
> + temperature = <85000>; /* 85C */
> + hysteresis = <2000>;
> + type = "passive";
> + };
> + };
> + };
> + };
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] add UniPhier thermal support Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
[PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Rob Herring <robh@kernel.org> - 2017-06-05 19:30 +0200
Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-06 04:50 +0200
[PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Keerthy <j-keerthy@ti.com> - 2017-05-29 12:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 04:50 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Keerthy <j-keerthy@ti.com> - 2017-05-30 05:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 06:10 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Eduardo Valentin <edubezval@gmail.com> - 2017-05-29 18:50 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 11:30 +0200
Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-05 10:50 +0200
[PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-06 05:10 +0200
[PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-29 11:20 +0200
Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Eduardo Valentin <edubezval@gmail.com> - 2017-05-29 18:40 +0200
Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-05-30 11:30 +0200
csiph-web