Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier expectations

From	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier expectations
Date	2017-06-08 04:50 +0200
Message-ID	<tPVGh-6Kh-5@gated-at.bofh.it> (permalink)
References	<tPKBd-7Z0-25@gated-at.bofh.it> <tPKKR-8hH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 07, 2017 at 04:00:02PM +0100, Edward Cree wrote:
> Some of the verifier's error messages have changed, and some constructs
>  that previously couldn't be verified are now accepted.
> 
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
>  tools/testing/selftests/bpf/test_verifier.c | 226 ++++++++++++++--------------
>  1 file changed, 116 insertions(+), 110 deletions(-)

imo this rewrite needs more than one additional test.
Like i counted at least 2 new verifier features (like negative and ptr & 0x40)
All the new logic needs to be covered by tests.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier  expectations Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2017-06-08 04:50 +0200
  Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier  expectations Edward Cree <ecree@solarflare.com> - 2017-06-08 17:30 +0200

csiph-web