Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1660639
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Jason A. Donenfeld" <Jason@zx2c4.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 04/13] security/keys: ensure RNG is seeded before use |
| Date | Thu, 08 Jun 2017 03:00:01 +0200 |
| Message-ID | <tPTXP-5yb-7@gated-at.bofh.it> (permalink) |
| References | <tPqM9-3tE-3@gated-at.bofh.it> <tPqMa-3tE-35@gated-at.bofh.it> <tPTEu-5rT-17@gated-at.bofh.it> |
| X-Original-To | "Theodore Ts'o" <tytso@mit.edu>, "Jason A. Donenfeld" <Jason@zx2c4.com>, Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, kernel-hardening@lists.openwall.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Miller <davem@davemloft.net>, Eric Biggers <ebiggers3@gmail.com>, David Howells <dhowells@redhat.com>, Mimi Zohar <zohar@linux.vnet.ibm.com>, David Safford <safford@us.ibm.com> |
| Dkim-Signature | v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :in-reply-to:references:from:date:message-id:subject:to :content-type; s=mail; bh=xnaAOjUozwcKh7h/rQ8BeRH5lzY=; b=dX8grl 3ubb7k0ijNUx5Nhb3Nz6wZNiO9cjYOVDw8T2zN6RMtZffndEpnXg2TmNwLVUeInz lamn58QEubvdWfKvbZidSOms/I9HLcBSonc5Wkq5F8zYsPu3hxlqFHbdJyCQjwN4 XHUpr0rIoFNOCjj47nWz6ogjTMAjR5vMhZclYekSSccHo786WoAwIbELaWqvCXvP db6hIseTlQDh2t2mocxCQSxaFV629du9goYUqPR5GzWgZ3FNTr/kgXs2iw+ATbX5 YZuvx6feE1TvdGRSAhsvmNTsszYcj6QXaeBOycZwf02KRfe9m6pQI/XcJGD65sV8 kJNH3BhFT4N0uhFg== |
| X-Gm-Message-State | AODbwcDohGMt/XtR5Hr6SNr35Zinp7bh+Ae6SeKRjJfo+FJQeuwaXPhG AU8CBue8jQpW4Lz7/3tw75s5Too73g== |
| X-Received | by 10.157.9.155 with SMTP id q27mr16498793otd.232.1496883010244; Wed, 07 Jun 2017 17:50:10 -0700 (PDT) |
| MIME-Version | 1.0 |
| X-Gmail-Original-Message-ID | <CAHmME9qbt70Oc0h_zfGqdrfTbrVsY4aUM-oUjpWHsU7PO7DZww@mail.gmail.com> |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 15 |
| Organization | linux.* mail to news gateway |
| X-Original-Date | Thu, 8 Jun 2017 02:50:09 +0200 |
| X-Original-Message-ID | <CAHmME9qbt70Oc0h_zfGqdrfTbrVsY4aUM-oUjpWHsU7PO7DZww@mail.gmail.com> |
| X-Original-References | <20170606174804.31124-1-Jason@zx2c4.com> <20170606174804.31124-5-Jason@zx2c4.com> <20170608003116.zgznzb37ms7wj4vl@thunk.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1660639 |
Show key headers only | View raw
On Thu, Jun 8, 2017 at 2:31 AM, Theodore Ts'o <tytso@mit.edu> wrote: > I'm guessing you changed key_alloc_serial() to return an int back when > you were thinking that you might use get_random_bytes_wait(), which > could return -ERESTARTSYS. > > Now that you're not doing this, but using get_random_u32() instead, > there's no point to change the function signature of > key_alloc_serial() and add an error check in key_alloc() that will > never fail, right? That's just adding a dead code path. Which the > compiler can probably optimize away, but why make the code slightly > harder to read than necessasry? Good catch, and thanks for reading these so thoroughly that you caught the churn artifacts. Do you want me to clean this up and resubmit, or are you planning on adjusting it in the dev branch?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v4 04/13] security/keys: ensure RNG is seeded before use Theodore Ts'o <tytso@mit.edu> - 2017-06-08 02:40 +0200
Re: [PATCH v4 04/13] security/keys: ensure RNG is seeded before use "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-08 03:00 +0200
Re: [PATCH v4 04/13] security/keys: ensure RNG is seeded before use "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-08 03:10 +0200
csiph-web