Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1660115
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members |
| Date | 2017-06-07 21:10 +0200 |
| Message-ID | <tPOv7-2fF-1@gated-at.bofh.it> (permalink) |
| References | <tPtK1-5mC-3@gated-at.bofh.it> <tPtTI-5H7-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Date: Tue, 6 Jun 2017 16:56:29 -0400 > @@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds, > bitmap_zero(members, ds->num_ports); > if (ds->index == info->sw_index) > set_bit(info->port, members); > + for (port = 0; port < ds->num_ports; ++port) > + if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port)) > + set_bit(port, members); Please use the more canonical "x++" post-increment in the for() statement. Thank you.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/5] net: dsa: add cross-chip VLAN support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-06 23:10 +0200
[PATCH net-next 1/5] net: dsa: mv88e6xxx: define membership on VLAN add Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-06 23:10 +0200
Re: [PATCH net-next 1/5] net: dsa: mv88e6xxx: define membership on VLAN add Florian Fainelli <f.fainelli@gmail.com> - 2017-06-07 21:40 +0200
[PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-06 23:10 +0200
Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members David Miller <davem@davemloft.net> - 2017-06-07 21:10 +0200
Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members Florian Fainelli <f.fainelli@gmail.com> - 2017-06-07 21:40 +0200
csiph-web