Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660116

Re: [PATCH 7/8] blk-mq: create hctx for each present CPU

Show all headers | View raw

On Wed, Jun 07, 2017 at 05:10:46PM +0800, Ming Lei wrote:
> One thing not sure is that we may need to handle new CPU hotplug
> after initialization. Without the CPU hotplug handler, system may
> not scale well when more CPUs are added to sockets.

Adding physical CPUs to sockets is a very rare activity, and we
should not optimize for it.  Taking CPUs that are physically present
offline and online is the case that is interesting, and that's what
this patchset changes.

> Another thing is that I don't see how NVMe handles this situation,
> blk_mq_update_nr_hw_queues() is called in nvme_reset_work(), so
> that means RESET need to be triggered after new CPUs are added to
> system?

Yes.

> I have tried to add new CPUs runtime on Qemu, and not see
> new hw queues are added no matter this patchset is applied or not.

Do you even see the CPUs in your VM?  For physical hotplug you'll
need to reserve spots in the cpumap beforehand.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 7/8] blk-mq: create hctx for each present CPU Christoph Hellwig <hch@lst.de> - 2017-06-03 16:10 +0200
  Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:20 +0200
  Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Ming Lei <ming.lei@redhat.com> - 2017-06-07 11:20 +0200
    Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Christoph Hellwig <hch@lst.de> - 2017-06-07 21:10 +0200
      Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Ming Lei <ming.lei@redhat.com> - 2017-06-08 04:30 +0200
  Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Omar Sandoval <osandov@osandov.com> - 2017-06-08 00:10 +0200
    Re: [PATCH 7/8] blk-mq: create hctx for each present CPU Christoph Hellwig <hch@lst.de> - 2017-06-08 09:00 +0200

csiph-web