Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters
Date	2017-06-07 18:30 +0200
Message-ID	<tPM0h-zo-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <tNa8N-48w-3@gated-at.bofh.it> <tNvdf-1cV-3@gated-at.bofh.it> <tNvdf-1cV-1@gated-at.bofh.it> <tP54Z-6tW-7@gated-at.bofh.it> <tP7Tc-8dq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 05, 2017 at 02:38:31PM -0700, Andrew Morton wrote:
> On Mon, 5 Jun 2017 14:35:11 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> 
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -5107,6 +5107,7 @@ static void build_zonelists(pg_data_t *pgdat)
> >   */
> >  static void setup_pageset(struct per_cpu_pageset *p, unsigned long batch);
> >  static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset);
> > +static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats);
> >  static void setup_zone_pageset(struct zone *zone);
> 
> There's a few kb there.  It just sits evermore unused after boot?

It's not the greatest, but it's nothing new. All the node stats we
have now used to be in the zone, i.e. the then bigger boot_pageset,
before we moved them to the node level. It just re-adds static boot
time space for them now.

Of course, if somebody has an idea on how to elegantly reuse that
memory after boot, that'd be cool. But we've lived with that footprint
for the longest time, so I don't think it's a showstopper.

Thread

[PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Johannes Weiner <hannes@cmpxchg.org> - 2017-05-30 20:20 +0200
  Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-05-31 11:20 +0200
    Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-05-31 13:40 +0200
      Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-01 12:10 +0200
        Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-05 20:40 +0200
          Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Andrew Morton <akpm@linux-foundation.org> - 2017-06-05 23:40 +0200
            Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-07 18:30 +0200
          Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-06 06:40 +0200
            Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-06 13:20 +0200
              Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-06 16:40 +0200

csiph-web