Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters
Date	2017-06-01 12:10 +0200
Message-ID	<tNvdf-1cV-1@gated-at.bofh.it> (permalink)
References	<tMTUl-2jI-5@gated-at.bofh.it> <tMTUl-2jI-17@gated-at.bofh.it> <tN7Xk-2RF-15@gated-at.bofh.it> <tNa8N-48w-3@gated-at.bofh.it> <tNvdf-1cV-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yury Norov <ynorov@caviumnetworks.com> writes:

> On Wed, May 31, 2017 at 01:39:00PM +0200, Heiko Carstens wrote:
>> On Wed, May 31, 2017 at 11:12:56AM +0200, Heiko Carstens wrote:
>> > On Tue, May 30, 2017 at 02:17:20PM -0400, Johannes Weiner wrote:
>> > > To re-implement slab cache vs. page cache balancing, we'll need the
>> > > slab counters at the lruvec level, which, ever since lru reclaim was
>> > > moved from the zone to the node, is the intersection of the node, not
>> > > the zone, and the memcg.
>> > > 
>> > > We could retain the per-zone counters for when the page allocator
>> > > dumps its memory information on failures, and have counters on both
>> > > levels - which on all but NUMA node 0 is usually redundant. But let's
>> > > keep it simple for now and just move them. If anybody complains we can
>> > > restore the per-zone counters.
>> > > 
>> > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>> > 
>> > This patch causes an early boot crash on s390 (linux-next as of today).
>> > CONFIG_NUMA on/off doesn't make any difference. I haven't looked any
>> > further into this yet, maybe you have an idea?
>
> The same on arm64.

And powerpc.

cheers

Thread

[PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Johannes Weiner <hannes@cmpxchg.org> - 2017-05-30 20:20 +0200
  Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-05-31 11:20 +0200
    Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-05-31 13:40 +0200
      Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-01 12:10 +0200
        Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-05 20:40 +0200
          Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Andrew Morton <akpm@linux-foundation.org> - 2017-06-05 23:40 +0200
            Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-07 18:30 +0200
          Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-06 06:40 +0200
            Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Michael Ellerman <mpe@ellerman.id.au> - 2017-06-06 13:20 +0200
              Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node  counters Johannes Weiner <hannes@cmpxchg.org> - 2017-06-06 16:40 +0200

csiph-web