Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns
Date	2017-06-07 15:50 +0200
Message-ID	<tPJvr-7jj-5@gated-at.bofh.it> (permalink)
References	<tNwj0-1RP-9@gated-at.bofh.it> <tNwj0-1RP-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 1, 2017 at 2:17 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> The uuid field in the nvme_ns structure represents the nguid field
> from the identify namespace command. And as NVMe 1.3 introduced an
> UUID in the NVMe Namespace Identification Descriptor this will
> collide.
>
> So rename the uuid to nguid to prevent any further
> confusion. Unfortunately we export the nguid to sysfs in the uuid
> sysfs attribute, but this can't be changed anymore without possibly
> breaking existing userspace.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Hannes Reinecke <hare@suse.com>

I suppose it should go through UUID tree?

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v2 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
  [PATCH v2 6/8] nvme: provide UUID value to userspace Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
    Re: [PATCH v2 6/8] nvme: provide UUID value to userspace Keith Busch <keith.busch@intel.com> - 2017-06-01 14:40 +0200
      Re: [PATCH v2 6/8] nvme: provide UUID value to userspace Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 15:10 +0200
  [PATCH v2 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
  [PATCH v2 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
  [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
    Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-07 15:50 +0200
    Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 15:50 +0200
  [PATCH v2 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
  [PATCH v2 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:20 +0200
  [PATCH v2 5/8] nvme: get list of namespace descriptors Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-01 13:30 +0200

csiph-web