Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document

From	Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document
Date	2017-06-07 14:40 +0200
Message-ID	<tPIpI-6D4-25@gated-at.bofh.it> (permalink)
References	<tNZbj-4Ci-1@gated-at.bofh.it> <tNZbj-4Ci-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Friday 02 June 2017 11:31 PM, Al Cooper wrote:
> Add DT bindings document for Broadcom STB USB PHYs
> 
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
>  .../bindings/phy/brcm,brcmstb-usb-phy.txt          | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> new file mode 100644
> index 0000000..e1e9b16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> @@ -0,0 +1,37 @@
> +Broadcom STB USB PHY
> +
> +Required properties:
> + - compatible: brcm,brcmstb-usb-phy
> + - reg: two offset and length pairs. The second pair specifies optional
> +        registers used by some of the SoCs that support USB 3.x

and the first pair?
> + - #phy-cells: Shall be 1 as it expects one argument for setting
> +	       the type of the PHY. Possible values are 0 (1.1 and 2.0),
> +	       1 (3.x)

It should use PHY_TYPE_USB2 or PHY_TYPE_USB3 (see include/dt-bindings/phy/phy.h).

Thanks
Kishon

Thread

[PATCH 0/3] Add Broadcom STB USB phy driver Al Cooper <alcooperx@gmail.com> - 2017-06-02 20:10 +0200
  [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper <alcooperx@gmail.com> - 2017-06-02 20:10 +0200
    Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding  document Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-07 14:40 +0200
    Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding  document Rob Herring <robh@kernel.org> - 2017-06-09 00:20 +0200
      Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper <al.cooper@broadcom.com> - 2017-06-12 22:20 +0200
        Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper <al.cooper@broadcom.com> - 2017-06-12 23:00 +0200
  [PATCH 1/3] soc: brcmstb: Add Product ID and Family ID helper functions Al Cooper <alcooperx@gmail.com> - 2017-06-02 20:10 +0200

csiph-web