Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API
Date	2017-06-05 23:30 +0200
Message-ID	<tP7Jw-8a4-11@gated-at.bofh.it> (permalink)
References	<tNhN0-CQ-17@gated-at.bofh.it> <tNhN1-CQ-47@gated-at.bofh.it> <tP2JP-54T-15@gated-at.bofh.it> <tP33g-5dS-127@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 05, 2017 at 07:23:05PM +0300, Andy Shevchenko wrote:
> > From a quick look over the tree it seems like both fru_id and
> > section_type should be declared as guid_t in
> > struct acpi_hest_generic_data.
> 
> 
> They are arrays of 16 u8:s.

As is the guid_t.

> And since it's defined in ACPI table definition I'm not sure we can
> change it.

If we always use 16 u8s as guid_t we might as well define the structure
as such, instead of all the casts that remove type safety.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-31 21:50 +0200
  Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID         API Christoph Hellwig <hch@lst.de> - 2017-06-05 18:10 +0200
    Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 18:30 +0200
      Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID         API Christoph Hellwig <hch@lst.de> - 2017-06-05 23:30 +0200

csiph-web