Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657787
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API |
| Date | 2017-06-05 18:30 +0200 |
| Message-ID | <tP33g-5dS-127@gated-at.bofh.it> (permalink) |
| References | <tNhN0-CQ-17@gated-at.bofh.it> <tNhN1-CQ-47@gated-at.bofh.it> <tP2JP-54T-15@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Mon, 2017-06-05 at 18:06 +0200, Christoph Hellwig wrote:
> > @@ -165,11 +165,11 @@ static int extlog_print(struct notifier_block
> > *nb, unsigned long val,
> > err_seq++;
> > gdata = (struct acpi_hest_generic_data *)(tmp + 1);
> > if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID)
> > - fru_id = (uuid_le *)gdata->fru_id;
> > + fru_id = (guid_t *)gdata->fru_id;
> > if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT)
> > fru_text = gdata->fru_text;
> > - sec_type = (uuid_le *)gdata->section_type;
> > - if (!uuid_le_cmp(*sec_type, CPER_SEC_PLATFORM_MEM)) {
> > + sec_type = (guid_t *)gdata->section_type;
>
> From a quick look over the tree it seems like both fru_id and
> section_type should be declared as guid_t in
> struct acpi_hest_generic_data.
They are arrays of 16 u8:s.
And since it's defined in ACPI table definition I'm not sure we can
change it.
>
> > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
>
> The "!" seems incorrect here.
Right.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-31 21:50 +0200
Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 18:10 +0200
Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 18:30 +0200
Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 23:30 +0200
csiph-web