Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API
Date	2017-06-05 19:30 +0200
Message-ID	<tP3cT-5hS-37@gated-at.bofh.it> (permalink)
References	<tNhN0-CQ-17@gated-at.bofh.it> <tNhN0-CQ-15@gated-at.bofh.it> <tP2JP-54T-7@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> > -		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> > -				 CPER_SEC_PLATFORM_MEM)) {
> > +		if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM))
> > {
> 
> The "!" here seems incorrect.
> 
> >  #ifdef CONFIG_ACPI_APEI_PCIEAER
> > -		else if (!uuid_le_cmp(*(uuid_le *)gdata-
> > >section_type,
> > -				      CPER_SEC_PCIE)) {
> > +		else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
> 
> Same here.

Thanks!
Are you going to fixup when applying or better me to send an updated
version?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-31 21:50 +0200
  Re: [Intel-gfx] [PATCH v2 2/5] ACPI / APEI: Switch to use new generic  UUID API Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-01 12:00 +0200
  Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 18:10 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 18:40 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 19:30 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 19:30 +0200

csiph-web