Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1657694

Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API
Date 2017-06-05 18:10 +0200
Message-ID <tP2JP-54T-7@gated-at.bofh.it> (permalink)
References <tNhN0-CQ-17@gated-at.bofh.it> <tNhN0-CQ-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> -		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> -				 CPER_SEC_PLATFORM_MEM)) {
> +		if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {

The "!" here seems incorrect.

>  #ifdef CONFIG_ACPI_APEI_PCIEAER
> -		else if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> -				      CPER_SEC_PCIE)) {
> +		else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {

Same here.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-31 21:50 +0200
  Re: [Intel-gfx] [PATCH v2 2/5] ACPI / APEI: Switch to use new generic  UUID API Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-01 12:00 +0200
  Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 18:10 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 18:40 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 19:30 +0200
    Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 19:30 +0200

csiph-web