Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656760

Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer

Show all headers | View raw

On Sun, 28 May 2017 23:17:57 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:

> Hi Paolo, Hi Jonathan,
> 
> On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> > On Sun, 28 May 2017 13:24:38 +0200
> > Paolo Cretaro <paolocretaro@gmail.com> wrote:
> >  
> >> Fix sparse warning: Using plain integer as NULL pointer
> >>
> >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>  
> > This looks fine to me, but ideally you should always try to include
> > the driver author - particularly in the case of patches to a recent
> > driver such as this one.
> >
> > To that end I've cc'd Martin.  
> thanks for spotting this (and providing a patch to fix it)
> this looks good to me, so:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> if you can wait until next weekend then I can also test this on real hardware.
I've applied it to the togreg branch of iio.git but as that always goes out
as testing for at least a few days first (which I will happily rebase) give
me a shout if anything goes wrong!

Jonathan
> 
> > Jonathan  
> >> ---
> >>  drivers/iio/adc/meson_saradc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> >> index 81cd39a57fe3..fb3f67a9ae1f 100644
> >> --- a/drivers/iio/adc/meson_saradc.c
> >> +++ b/drivers/iio/adc/meson_saradc.c
> >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev)
> >>               if (!meson_sar_adc_get_fifo_count(indio_dev))
> >>                       break;
> >>
> >> -             regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0);
> >> +             regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL);
> >>       }
> >>  }
> >>  
> >  
> 
> Regards,
> Martin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-05-28 13:30 +0200
  Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for  pointer Jonathan Cameron <jic23@kernel.org> - 2017-05-28 16:50 +0200
    Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-05-28 20:00 +0200
    Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-05-28 23:20 +0200
      Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for  pointer Jonathan Cameron <jic23@kernel.org> - 2017-06-03 11:00 +0200
        Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-04 15:40 +0200
          Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-06-06 11:30 +0200

csiph-web