Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652186
| From | Paolo Cretaro <paolocretaro@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer |
| Date | 2017-05-28 20:00 +0200 |
| Message-ID | <tMaDT-56H-1@gated-at.bofh.it> (permalink) |
| References | <tM4yt-1j1-9@gated-at.bofh.it> <tM7G2-3f9-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28/05/2017 16:43, Jonathan Cameron wrote: > On Sun, 28 May 2017 13:24:38 +0200 > Paolo Cretaro <paolocretaro@gmail.com> wrote: > >> Fix sparse warning: Using plain integer as NULL pointer >> >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> > This looks fine to me, but ideally you should always try to include > the driver author - particularly in the case of patches to a recent > driver such as this one. Sure, thanks for pointing this out, I just felt a bit embarrassed to bother too many people with such a trivial patch. Paolo > > To that end I've cc'd Martin. > > Jonathan >> --- >> drivers/iio/adc/meson_saradc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> index 81cd39a57fe3..fb3f67a9ae1f 100644 >> --- a/drivers/iio/adc/meson_saradc.c >> +++ b/drivers/iio/adc/meson_saradc.c >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) >> if (!meson_sar_adc_get_fifo_count(indio_dev)) >> break; >> >> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); >> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); >> } >> } >> >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-05-28 13:30 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Jonathan Cameron <jic23@kernel.org> - 2017-05-28 16:50 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-05-28 20:00 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-05-28 23:20 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Jonathan Cameron <jic23@kernel.org> - 2017-06-03 11:00 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-04 15:40 +0200
Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro <paolocretaro@gmail.com> - 2017-06-06 11:30 +0200
csiph-web