Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
Date	2017-06-05 02:00 +0200
Message-ID	<tONB7-3oN-3@gated-at.bofh.it> (permalink)
References	<tNWds-2wl-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Fri,  2 Jun 2017 15:58:27 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Cast entry to an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.
> 
> Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Like others have suggested, probably making 'entry' signed is
a better fix.

I was initially worried that STMMAC_GET_ENTRY() might become
more expensive if it was implemented using '%' but it is using
'and' masking instead which doesn't have that kind of problem.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value Colin King <colin.king@canonical.com> - 2017-06-02 17:00 +0200
  Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 18:00 +0200
    Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Colin Ian King <colin.king@canonical.com> - 2017-06-03 18:40 +0200
      Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Julia Lawall <julia.lawall@lip6.fr> - 2017-06-03 19:00 +0200
      Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 19:20 +0200
  Re: [PATCH] net: stmmac: ensure jumbo_frm error return is  correctly checked for -ve value David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200

csiph-web