Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656311

[PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The current comparison of entry < 0 will never be true since entry is an
unsigned integer. Cast entry to an int to ensure -ve error return values
from the call to jumbo_frm are correctly being caught.

Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 68a188e74c54..5cc19506ba85 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2996,7 +2996,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
 	if (unlikely(is_jumbo) && likely(priv->synopsys_id <
 					 DWMAC_CORE_4_00)) {
 		entry = priv->hw->mode->jumbo_frm(tx_q, skb, csum_insertion);
-		if (unlikely(entry < 0))
+		if (unlikely((int)entry < 0))
 			goto dma_map_err;
 	}
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value Colin King <colin.king@canonical.com> - 2017-06-02 17:00 +0200
  Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 18:00 +0200
    Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Colin Ian King <colin.king@canonical.com> - 2017-06-03 18:40 +0200
      Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Julia Lawall <julia.lawall@lip6.fr> - 2017-06-03 19:00 +0200
      Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly  checked for -ve value Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 19:20 +0200
  Re: [PATCH] net: stmmac: ensure jumbo_frm error return is  correctly checked for -ve value David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200

csiph-web