Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080
Date	Wed, 31 May 2017 22:00:01 +0200
Message-ID	<tNhWF-Ge-1@gated-at.bofh.it> (permalink)
References	<tKH1g-4vB-33@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=79JPd8TExDcR2j/Pr2GiwP5c90dL6VqV0wdAl/8rFLQ=; b=CUU7Ph48aXA/Cj9SZ+vwqTjE2XqeDp0CYLnrtyx9ywwKdpUulYsM4KWDUxKRQTEtL5K/m6+5UTgtYpMkdQmWIv7LV3PX8bCYSztMCr+tExzdpRgGzm3n8S3VD23xRStqYmxohbVgG61w1MOEYFAmRspY87OKeIn8Kem76R1+R+c=;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Eric Anholt <eric@anholt.net>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 31 May 2017 20:58:49 +0100
X-Original-Message-ID	<20170531195849.GD27796@n2100.armlinux.org.uk>
X-Original-References	<20170524155845.1778223-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1654592

Show key headers only | View raw

On Wed, May 24, 2017 at 05:58:34PM +0200, Arnd Bergmann wrote:
> While trying a fix a build warning unrelated to s3c64xx, I ran into
> a circular dependency:
> 
> drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC
> drivers/video/fbdev/Kconfig:63: symbol FB_DDC is selected by FB_CYBER2000_DDC
> drivers/video/fbdev/Kconfig:381: symbol FB_CYBER2000_DDC depends on FB_CYBER2000
> drivers/video/fbdev/Kconfig:369: symbol FB_CYBER2000 depends on FB
> drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER
> drivers/gpu/drm/Kconfig:72: symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
> drivers/gpu/drm/Kconfig:137: symbol DRM_KMS_CMA_HELPER is selected by DRM_PL111
> drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on ARM_AMBA
> drivers/amba/Kconfig:1: symbol ARM_AMBA is selected by S3C64XX_PL080
> arch/arm/mach-s3c64xx/Kconfig:42: symbol S3C64XX_PL080 default value contains DMADEVICES
> drivers/dma/Kconfig:5: symbol DMADEVICES is selected by SND_SOC_SH4_SIU
> sound/soc/sh/Kconfig:29: symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR
> sound/soc/sh/Kconfig:59: symbol SND_SIU_MIGOR depends on I2C
> 
> The I2C and FB dependencies are hard to untangle, but I notice that
> S3C64XX_PL080 selecting ARM_AMBA is one piece of the puzzle that
> can easily be avoided, as ARCH_S3C64XX already select ARM_AMBA.
> Removing the redundant 'select' now can help us in the future if we
> run into a variation of the same dependency.

Yes, selecting ARM_AMBA from drivers is definitely not right; this
symbol should be selected only by platforms that want AMBA primecell
bus support, not by drivers, precisely because of these dependency
issues.

There's another case where ARM_AMBA is selected that probably needs
fixing - the coresight hwtracing code.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-31 22:00 +0200
  Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Arnd Bergmann <arnd@arndb.de> - 2017-05-31 22:30 +0200
    Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-06-01 16:50 +0200

csiph-web