Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654609

Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080

Show all headers | View raw

On Wed, May 31, 2017 at 9:58 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> On Wed, May 24, 2017 at 05:58:34PM +0200, Arnd Bergmann wrote:
> Yes, selecting ARM_AMBA from drivers is definitely not right; this
> symbol should be selected only by platforms that want AMBA primecell
> bus support, not by drivers, precisely because of these dependency
> issues.
>
> There's another case where ARM_AMBA is selected that probably needs
> fixing - the coresight hwtracing code.

[Adding Mathieu to cc]

Mathieu,

do you remember how we ended up with this?

menuconfig CORESIGHT
       bool "CoreSight Tracing Support"
       select ARM_AMBA

As Russell says, probably shouldn't select that symbol, most likely
we want either the individual drivers that register an amba_driver to have
a 'depends on ARM_AMBA' or alternatively replace the 'select' with 'depends
on' for the entire subsystem.

        Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-31 22:00 +0200
  Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Arnd Bergmann <arnd@arndb.de> - 2017-05-31 22:30 +0200
    Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-06-01 16:50 +0200

csiph-web