Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register()

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register()
Date	2017-05-29 11:20 +0200
Message-ID	<tMp0e-6bg-5@gated-at.bofh.it> (permalink)
References	<tKOm5-tO-7@gated-at.bofh.it> <tKOm6-tO-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 25 May 2017 11:49:13 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> Use mtd_device_register() instead of mtd_device_parse_register() to
> eliminate two unused parameters.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> Changes in v2
> - collect review/test from Andrew
> Changes in v3:
> - None
> Changes in v4:
> - None
> 
>  drivers/mtd/devices/mchp23k256.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
> index 9d8306a15833..2542f5b8b63f 100644
> --- a/drivers/mtd/devices/mchp23k256.c
> +++ b/drivers/mtd/devices/mchp23k256.c
> @@ -151,9 +151,8 @@ static int mchp23k256_probe(struct spi_device *spi)
>  	flash->mtd._read	= mchp23k256_read;
>  	flash->mtd._write	= mchp23k256_write;
>  
> -	err = mtd_device_parse_register(&flash->mtd, NULL, NULL,
> -					data ? data->parts : NULL,
> -					data ? data->nr_parts : 0);
> +	err = mtd_device_register(&flash->mtd, data ? data->parts : NULL,
> +				  data ? data->nr_parts : 0);
>  	if (err)
>  		return err;
>

Thread

[PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
  [PATCH v4 3/5] mtd: handle partitioning on devices with 0 erasesize Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 3/5] mtd: handle partitioning on devices with 0  erasesize Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
  [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
  [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Rob Herring <robh@kernel.org> - 2017-05-31 20:00 +0200
  [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Brian Norris <computersforpeace@gmail.com> - 2017-06-01 20:50 +0200
  [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Rob Herring <robh@kernel.org> - 2017-05-31 20:00 +0200
  Re: [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Brian Norris <computersforpeace@gmail.com> - 2017-06-01 20:50 +0200

csiph-web