Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support
Date	2017-05-29 11:20 +0200
Message-ID	<tMp0e-6bg-19@gated-at.bofh.it> (permalink)
References	<tKOm5-tO-7@gated-at.bofh.it> <tKOm6-tO-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 25 May 2017 11:49:15 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> Setting the of_node for the mtd device allows the generic mtd code to
> setup the partitions. Additionally we must specify a non-zero erasesize
> for the partitions to be writeable.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> Changes in v2
> - collect revew/test from Andrew
> Changes in v3:
> - remove setting of erasesize
> Changes in v4:
> - none
> 
>  drivers/mtd/devices/mchp23k256.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
> index 2542f5b8b63f..3e5feb454644 100644
> --- a/drivers/mtd/devices/mchp23k256.c
> +++ b/drivers/mtd/devices/mchp23k256.c
> @@ -143,6 +143,7 @@ static int mchp23k256_probe(struct spi_device *spi)
>  
>  	data = dev_get_platdata(&spi->dev);
>  
> +	mtd_set_of_node(&flash->mtd, spi->dev.of_node);
>  	flash->mtd.dev.parent	= &spi->dev;
>  	flash->mtd.type		= MTD_RAM;
>  	flash->mtd.flags	= MTD_CAP_RAM;

Thread

[PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
  [PATCH v4 3/5] mtd: handle partitioning on devices with 0 erasesize Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 3/5] mtd: handle partitioning on devices with 0  erasesize Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
  [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
  [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Rob Herring <robh@kernel.org> - 2017-05-31 20:00 +0200
  [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Brian Norris <computersforpeace@gmail.com> - 2017-06-01 20:50 +0200
  [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-25 02:00 +0200
    Re: [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 11:20 +0200
    Re: [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Rob Herring <robh@kernel.org> - 2017-05-31 20:00 +0200
  Re: [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Brian Norris <computersforpeace@gmail.com> - 2017-06-01 20:50 +0200

csiph-web