Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv
Date	2017-05-30 22:00 +0200
Message-ID	<tMVt7-37M-5@gated-at.bofh.it> (permalink)
References	<tMUdH-2qm-5@gated-at.bofh.it> <tMUdH-2qm-3@gated-at.bofh.it> <tMUGK-2PS-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

> I actually have a patch pending that adds support for HW
> insertion/extraction of switch tags (broadcom HW supports that) which
> require the orig_dev to be there so we know what features are supported
> by the master network device.

Is orig_dev really needed in the tagging implementation, or only in the
layer above? (dsa_slave_xmit and dsa_switch_rcv.)

> Do you mind dropping this one from your patch series?

I don't mind if they are actually needed in taggers. I'd wait for
reviews of the other patches before respinning though.

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 20:40 +0200
  Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of  tagger rcv Florian Fainelli <f.fainelli@gmail.com> - 2017-05-30 21:10 +0200
    Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of  tagger rcv Florian Fainelli <f.fainelli@gmail.com> - 2017-05-30 22:00 +0200
      Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 22:10 +0200
    Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 22:00 +0200

csiph-web