Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653507

Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv

Show all headers | View raw

Hey Vivien,

On 05/30/2017 11:33 AM, Vivien Didelot wrote:
> The struct dsa_device_ops defines the rcv function with 2 unused
> arguments struct packet_type *pt, and struct net_device *orig_dev.
> 
> This patch removes them from the definition and implementations.
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

I actually have a patch pending that adds support for HW
insertion/extraction of switch tags (broadcom HW supports that) which
require the orig_dev to be there so we know what features are supported
by the master network device.

Do you mind dropping this one from your patch series?

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 20:40 +0200
  Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of  tagger rcv Florian Fainelli <f.fainelli@gmail.com> - 2017-05-30 21:10 +0200
    Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of  tagger rcv Florian Fainelli <f.fainelli@gmail.com> - 2017-05-30 22:00 +0200
      Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 22:10 +0200
    Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 22:00 +0200

csiph-web