Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection

From	Ralph Sennhauser <ralph.sennhauser@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection
Date	2017-05-30 17:20 +0200
Message-ID	<tMR69-A4-15@gated-at.bofh.it> (permalink)
References	<tMOrD-7i1-3@gated-at.bofh.it>
Organization	none

Show all headers | View raw

Hi Richard

On Tue, 30 May 2017 14:28:47 +0200
Richard Genoud <richard.genoud@gmail.com> wrote:

> The blink counter A was always selected because 0 was forced in the
> blink select counter register.
> The variable 'set' was obviously there to be used as the register
> value, selecting the B counter when id==1 and A counter when id==0.
> 
> Tested on clearfog-pro (Marvell 88F6828)

As stated in the other thread, testing on clearfog-pro is likely bogus,
still the fix is correct.

Reviewed-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>

Thanks
Ralph

> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>  drivers/gpio/gpio-mvebu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 19a92efabbef..cdef2c78cb3b 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -747,7 +747,7 @@ static int mvebu_pwm_probe(struct platform_device
> *pdev, set = U32_MAX;
>  	else
>  		return -EINVAL;
> -	writel_relaxed(0,
> mvebu_gpioreg_blink_counter_select(mvchip));
> +	writel_relaxed(set,
> mvebu_gpioreg_blink_counter_select(mvchip)); 
>  	mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm),
> GFP_KERNEL); if (!mvpwm)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] gpio: mvebu: fix blink counter register selection Richard Genoud <richard.genoud@gmail.com> - 2017-05-30 14:30 +0200
  Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-05-30 15:10 +0200
  Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-05-30 15:10 +0200
  Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-30 17:20 +0200

csiph-web