Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653308
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 0/7] net: dsa: tagger simplification |
| Date | 2017-05-30 17:20 +0200 |
| Message-ID | <tMR69-A4-11@gated-at.bofh.it> (permalink) |
| References | <tMQjL-8vK-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 30, 2017 at 10:21:24AM -0400, Vivien Didelot wrote:
> The DSA layer has a dsa_device_ops structure containing two members to
> tag and untag the proprietary switch header, called xmit and rcv.
>
> The switch tree and slave private structures respectively hold a useless
> copy of the rcv and xmit functions. The tagging implementations use
> useless goto labels and only the rcv caller (partially) handles the SKB
> freeing. The rcv function also contains unused arguments.
>
> This patchset removes the copy of rcv and xmit functions, the unused
> arguments of the rcv signature and the useless labels, and handles
> freeing of the SKB in the xmit caller.
Hi Vivien
Since these changes are dealing with the hot path of the network
stack, it would be good to see some performance results. In
particular, from a high performance machine, 10Gbps interfaces, where
DSA is enabled, as a distro kernel might have.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net-next 0/7] net: dsa: tagger simplification Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
[PATCH net-next 3/7] net: dsa: remove unused arguments of tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
Re: [PATCH net-next 3/7] net: dsa: remove unused arguments of tagger rcv Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:20 +0200
[PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
Re: [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:10 +0200
Re: [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code David Miller <davem@davemloft.net> - 2017-05-30 17:20 +0200
Re: [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 18:00 +0200
Re: [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 18:20 +0200
Re: [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Andrew Lunn <andrew@lunn.ch> - 2017-05-30 18:20 +0200
[PATCH net-next 7/7] net: dsa: factor skb freeing on xmit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
Re: [PATCH net-next 7/7] net: dsa: factor skb freeing on xmit Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:40 +0200
[PATCH net-next 5/7] net: dsa: remove useless goto label in tagger rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
[PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
Re: [PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:10 +0200
Re: [PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree David Miller <davem@davemloft.net> - 2017-05-30 17:20 +0200
Re: [PATCH net-next 0/7] net: dsa: tagger simplification Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:20 +0200
csiph-web