Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1653261

Re: [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K

From Marc Zyngier <marc.zyngier@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K
Date 2017-05-30 16:10 +0200
Message-ID <tMQ0q-8oA-11@gated-at.bofh.it> (permalink)
References <tMLtL-5qE-3@gated-at.bofh.it> <tMLtN-5qE-49@gated-at.bofh.it>
Organization ARM Ltd

Show all headers | View raw


On 30/05/17 10:16, Thomas Petazzoni wrote:
> This commit modifies the Marvell EBU Armada 7K and 8K Device Tree files
> to describe the ICU and GICP units, and use ICU interrupts for all
> devices in the CP110 blocks.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-ap806.dtsi      |  5 ++
>  .../boot/dts/marvell/armada-cp110-master.dtsi      | 60 +++++++++++++---------
>  .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 54 ++++++++++---------
>  3 files changed, 71 insertions(+), 48 deletions(-)
> 

[...]

> @@ -221,13 +229,13 @@
>  			cps_crypto: crypto@800000 {
>  				compatible = "inside-secure,safexcel-eip197";
>  				reg = <0x800000 0x200000>;
> -				interrupts = <GIC_SPI 34 (IRQ_TYPE_EDGE_RISING
> +				interrupts = <ICU_GRP_NSR 87 (IRQ_TYPE_EDGE_RISING
>  				| IRQ_TYPE_LEVEL_HIGH)>,

I've already mentioned this in a separate thread to Antoine, but it'd be
good to fix this non-sensical configuration.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 11:20 +0200
  [PATCH 1/6] dt-bindings: interrupt-controller: add DT binding for the Marvell GICP Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 11:20 +0200
  [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 11:20 +0200
    Re: [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada  7K/8K Marc Zyngier <marc.zyngier@arm.com> - 2017-05-30 16:10 +0200
      Re: [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada  7K/8K Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 16:30 +0200
  Re: [PATCH 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Marc Zyngier <marc.zyngier@arm.com> - 2017-05-30 16:20 +0200

csiph-web