Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency
Date	2017-05-30 12:00 +0200
Message-ID	<tMM6w-5FJ-37@gated-at.bofh.it> (permalink)
References	<tMsr8-8qg-21@gated-at.bofh.it> <tMw1I-2zI-9@gated-at.bofh.it> <tMLk5-5mP-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:03 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>>
>>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>>
>>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I already sent a combined patch fixing these two deps earlier today,
>> good that we are several at it :)
>
> Hmm... issues like these are actually the reasons why the of_node member
> of struct device does not depend on CONFIG_OF?

It's a bit of kludginess-vs-footprint thing I guess, you gain a pointer,
you loose a bit of Kconfig and #ifdefs.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
  [PATCH 2/2] pinctrl: ingenic: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
  Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 18:50 +0200
    Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-30 11:10 +0200
      Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Linus Walleij <linus.walleij@linaro.org> - 2017-05-30 12:00 +0200

csiph-web