Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652981

Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency

Show all headers | View raw

On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>
>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>
>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I already sent a combined patch fixing these two deps earlier today,
> good that we are several at it :)

Hmm... issues like these are actually the reasons why the of_node member
of struct device does not depend on CONFIG_OF?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
  [PATCH 2/2] pinctrl: ingenic: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
  Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 18:50 +0200
    Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-30 11:10 +0200
      Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency Linus Walleij <linus.walleij@linaro.org> - 2017-05-30 12:00 +0200

csiph-web