Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652807
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm, tpmrm: Mark tpmrm_write as static |
| Date | Tue, 30 May 2017 06:50:01 +0200 |
| Message-ID | <tMHgt-2mn-3@gated-at.bofh.it> (permalink) |
| References | <tKTF7-45C-9@gated-at.bofh.it> |
| X-Original-To | Peter Huewe <peterhuewe@gmx.de> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.38,417,1491289200"; d="scan'208";a="1175902439" |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 30 |
| X-Original-Cc | jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 30 May 2017 07:46:20 +0300 |
| X-Original-Message-ID | <20170530044501.pckpqfkzp3h54bqm@intel.com> |
| X-Original-References | <20170525054305.15721-1-peterhuewe@gmx.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1652807 |
Show key headers only | View raw
On Thu, May 25, 2017 at 07:43:05AM +0200, Peter Huewe wrote:
> sparse complains that tpmrm_write can be made static, and since it is
> right we make it static.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpmrm-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c
> index c636e7f..1a0e97a 100644
> --- a/drivers/char/tpm/tpmrm-dev.c
> +++ b/drivers/char/tpm/tpmrm-dev.c
> @@ -45,7 +45,7 @@ static int tpmrm_release(struct inode *inode, struct file *file)
> return 0;
> }
>
> -ssize_t tpmrm_write(struct file *file, const char __user *buf,
> +static ssize_t tpmrm_write(struct file *file, const char __user *buf,
> size_t size, loff_t *off)
> {
> struct file_priv *fpriv = file->private_data;
> --
> 2.10.2
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] tpm, tpmrm: Mark tpmrm_write as static Peter Huewe <peterhuewe@gmx.de> - 2017-05-25 07:40 +0200 Re: [PATCH] tpm, tpmrm: Mark tpmrm_write as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-30 06:50 +0200
csiph-web