Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650180 > unrolled thread
| Started by | Peter Huewe <peterhuewe@gmx.de> |
|---|---|
| First post | 2017-05-25 07:40 +0200 |
| Last post | 2017-05-30 06:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] tpm, tpmrm: Mark tpmrm_write as static Peter Huewe <peterhuewe@gmx.de> - 2017-05-25 07:40 +0200
Re: [PATCH] tpm, tpmrm: Mark tpmrm_write as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-30 06:50 +0200
| From | Peter Huewe <peterhuewe@gmx.de> |
|---|---|
| Date | 2017-05-25 07:40 +0200 |
| Subject | [PATCH] tpm, tpmrm: Mark tpmrm_write as static |
| Message-ID | <tKTF7-45C-9@gated-at.bofh.it> |
sparse complains that tpmrm_write can be made static, and since it is
right we make it static.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/char/tpm/tpmrm-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c
index c636e7f..1a0e97a 100644
--- a/drivers/char/tpm/tpmrm-dev.c
+++ b/drivers/char/tpm/tpmrm-dev.c
@@ -45,7 +45,7 @@ static int tpmrm_release(struct inode *inode, struct file *file)
return 0;
}
-ssize_t tpmrm_write(struct file *file, const char __user *buf,
+static ssize_t tpmrm_write(struct file *file, const char __user *buf,
size_t size, loff_t *off)
{
struct file_priv *fpriv = file->private_data;
--
2.10.2
[toc] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-05-30 06:50 +0200 |
| Message-ID | <tMHgt-2mn-3@gated-at.bofh.it> |
| In reply to | #1650180 |
On Thu, May 25, 2017 at 07:43:05AM +0200, Peter Huewe wrote:
> sparse complains that tpmrm_write can be made static, and since it is
> right we make it static.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpmrm-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c
> index c636e7f..1a0e97a 100644
> --- a/drivers/char/tpm/tpmrm-dev.c
> +++ b/drivers/char/tpm/tpmrm-dev.c
> @@ -45,7 +45,7 @@ static int tpmrm_release(struct inode *inode, struct file *file)
> return 0;
> }
>
> -ssize_t tpmrm_write(struct file *file, const char __user *buf,
> +static ssize_t tpmrm_write(struct file *file, const char __user *buf,
> size_t size, loff_t *off)
> {
> struct file_priv *fpriv = file->private_data;
> --
> 2.10.2
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web