Re: [PATCH v3] Input: mousedev - fix implicit conversion warning

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Input: mousedev - fix implicit conversion warning
Date	2017-05-30 04:50 +0200
Message-ID	<tMFom-XX-7@gated-at.bofh.it> (permalink)
References	<tLpvj-7E0-3@gated-at.bofh.it> <tLpEZ-7Hk-11@gated-at.bofh.it> <tLqUp-ef-11@gated-at.bofh.it> <tMywx-4rU-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 29, 2017 at 12:22:52PM -0700, Nick Desaulniers wrote:
> On Fri, May 26, 2017 at 10:07:46AM -0700, Dmitry Torokhov wrote:
> > If you look at the code of this fucntion we really use ps2_data as
> > signed in calculations, and this change would break that. While making
> > ps2_data u8 might be beneficial we'd need to rework mousedev_packet() to
> > use signed temporaries for dx, dy and dz before stufifng them into
> > ps2_data.
> 
> Is your recommendation then to stick with the simple cast as in V1 of
> this patch, or stick with u8 and rework mousedev_packet()?

I think casts are often mysterious, so, unless we'll end up with worse
object code, I'd switch to u8 and temps.

-- 
Dmitry

Thread

[PATCH] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 07:30 +0200
  [PATCH v2] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 17:40 +0200
    [PATCH v3] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 17:50 +0200
      Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-26 19:10 +0200
        Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-29 21:30 +0200
          Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-30 04:50 +0200
      [PATCH v4] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-30 07:50 +0200
        Re: [PATCH v4] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-06 18:20 +0200

csiph-web