Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651084
| From | Nick Desaulniers <nick.desaulniers@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] Input: mousedev - fix implicit conversion warning |
| Date | 2017-05-26 07:30 +0200 |
| Message-ID | <tLfYZ-1JS-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Clang warns:
drivers/input/mousedev.c:653:63: error: implicit conversion from 'int'
to 'signed char' changes value from 200 to -56
[-Wconstant-conversion]
client->ps2[1] = 0x60; client->ps2[2] = 3; client->ps2[3] = 200;
~ ^~~
As far as I can tell, from
http://www.computer-engineering.org/ps2mouse/
Under "Command Set" > "0xE9 (Status Request)"
the value 200 is a valid sample rate. An explicit cast silences this
warning.
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
drivers/input/mousedev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index 0e0ff84088fd..816e2431bba8 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -650,7 +650,9 @@ static void mousedev_generate_response(struct mousedev_client *client,
break;
case 0xe9: /* Get info */
- client->ps2[1] = 0x60; client->ps2[2] = 3; client->ps2[3] = 200;
+ client->ps2[1] = 0x60;
+ client->ps2[2] = 3;
+ client->ps2[3] = (char) 200;
client->bufsiz = 4;
break;
--
2.11.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 07:30 +0200
[PATCH v2] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 17:40 +0200
[PATCH v3] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 17:50 +0200
Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-26 19:10 +0200
Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-29 21:30 +0200
Re: [PATCH v3] Input: mousedev - fix implicit conversion warning Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-30 04:50 +0200
[PATCH v4] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-30 07:50 +0200
Re: [PATCH v4] Input: mousedev - fix implicit conversion warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-06 18:20 +0200
csiph-web