Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device

From	Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device
Date	2017-05-28 19:10 +0200
Message-ID	<tM9Rv-4Px-3@gated-at.bofh.it> (permalink)
References	<tM5Ed-1Z0-1@gated-at.bofh.it> <tM5Ee-1Z0-9@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Sun, 28 May 2017 14:30:35 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> Do not call dev_warn with a NULL device, this silence the following 2
> warnings:
> 
> [   14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
> [   14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO
> 
> We could switch to using pr_warn for dev == NULL instead, but as comments
> in the source indicate, the check for these 2 special gmin variables with
> a NULL device is a workaround for 2 specific evaluation boards, so
> completely silencing the missing warning for these actually is a good
> thing.

At which point real missing variables won't get reported so NAK. I think
the right fix is to make the offending callers pass

	subdev->dev

which if my understanding of the subdevices is correct should pass the
right valid device field from the atomisp.

Please also cc me if you are proposing patches this driver - and also
linux-media.

Alan

Thread

[PATCH v5 1/7] staging: atomisp: Fix calling efivar_entry_get() with unaligned arguments Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200
  [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200
    Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a  NULL device Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 19:10 +0200
      Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL  device Hans de Goede <hdegoede@redhat.com> - 2017-05-28 20:30 +0200
        Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a  NULL device Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 22:10 +0200
  [PATCH v5 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200

csiph-web