Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652122
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device |
| Date | 2017-05-28 14:40 +0200 |
| Message-ID | <tM5Ee-1Z0-9@gated-at.bofh.it> (permalink) |
| References | <tM5Ed-1Z0-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Do not call dev_warn with a NULL device, this silence the following 2
warnings:
[ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
[ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO
We could switch to using pr_warn for dev == NULL instead, but as comments
in the source indicate, the check for these 2 special gmin variables with
a NULL device is a workaround for 2 specific evaluation boards, so
completely silencing the missing warning for these actually is a good
thing.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
index 104fea2f8697..3fea81ea5dbd 100644
--- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
@@ -689,7 +689,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out, size_t *
if (ret == 0) {
memcpy(out, ev->var.Data, ev->var.DataSize);
*out_len = ev->var.DataSize;
- } else {
+ } else if (dev) {
dev_warn(dev, "Failed to find gmin variable %s\n", var8);
}
--
2.13.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 1/7] staging: atomisp: Fix calling efivar_entry_get() with unaligned arguments Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200
[PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200
Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 19:10 +0200
Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device Hans de Goede <hdegoede@redhat.com> - 2017-05-28 20:30 +0200
Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 22:10 +0200
[PATCH v5 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control Hans de Goede <hdegoede@redhat.com> - 2017-05-28 14:40 +0200
csiph-web