Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652128

Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization
Date 2017-05-28 16:00 +0200
Message-ID <tM6TD-2Jg-3@gated-at.bofh.it> (permalink)
References <tLc54-7AA-5@gated-at.bofh.it> <tLj6y-3Cw-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, May 26, 2017 at 10:48 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:

> The recent changes made the fttmr010 to be more generic and support different
> timers with a very few differences like moxart or aspeed.
>
> The aspeed timer uses a countdown and there is a test against the aspeed2400
> compatible string to set a flag.
>
> With the previous patch, we added the aspeed2500 compatible string but without
> taking care of setting the countdown flag.
>
> Fix this by specifiying a init function and pass the aspeed flag to a common
> init function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Sorry for the mistake :(
I don't have the Aspeed systems myself but I bet this works.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] clocksource: moxart: Add AST2500 compatible string Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-05-25 22:30 +0200
  Re: [PATCH] clocksource: moxart: Add AST2500 compatible string Andrew Jeffery <andrew@aj.id.au> - 2017-05-26 03:20 +0200
    [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-05-26 10:50 +0200
      Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization Linus Walleij <linus.walleij@linaro.org> - 2017-05-28 16:00 +0200
      Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500  initialization Andrew Jeffery <andrew@aj.id.au> - 2017-05-29 08:10 +0200
        Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500  initialization Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-05-29 09:50 +0200
          Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization Joel Stanley <joel@jms.id.au> - 2017-05-30 06:40 +0200
  Re: [PATCH] clocksource: moxart: Add AST2500 compatible string Linus Walleij <linus.walleij@linaro.org> - 2017-05-28 16:10 +0200

csiph-web