Re: [PATCH 7/7] DWARF: add the config option

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] DWARF: add the config option
Date	2017-05-26 09:00 +0200
Message-ID	<tLho6-2vy-11@gated-at.bofh.it> (permalink)
References	(3 earlier) <tECdY-30b-3@gated-at.bofh.it> <tIXa9-7Bx-7@gated-at.bofh.it> <tIXjP-7UF-13@gated-at.bofh.it> <tIXDb-823-15@gated-at.bofh.it> <tIXMR-86v-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/19/2017, 11:35 PM, Josh Poimboeuf wrote:
>   https://github.com/jpoimboe/linux/blob/undwarf/arch/x86/kernel/unwind_undwarf.c

JFYI, it crashes in sha1_transform_avx due to crypto changes. You
perhaps missed that this beast uses ebp (not rbp) register for
computations. I had to do:

--- a/arch/x86/crypto/sha1_ssse3_asm.S
+++ b/arch/x86/crypto/sha1_ssse3_asm.S
@@ -37,7 +37,7 @@
 #define REG_A  %ecx
 #define REG_B  %esi
 #define REG_C  %edi
-#define REG_D  %ebp
+#define REG_D  %r12d
 #define REG_E  %edx

 #define REG_T1 %eax
@@ -74,6 +74,7 @@
        SYM_FUNC_START(\name)

        push    %rbx
+       push    %r12
        push    %rbp

        mov     %rsp, %rbp
@@ -99,6 +100,7 @@
        rep stosq

        leaveq                          # deallocate workspace
+       pop     %r12
        pop     %rbx
        ret


I am afraid there are more of these, e.g. in aesni-intel_asm.S.

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/7] DWARF: add the config option Jiri Slaby <jslaby@suse.cz> - 2017-05-26 09:00 +0200
  Re: [PATCH 7/7] DWARF: add the config option Jiri Slaby <jslaby@suse.cz> - 2017-05-26 13:40 +0200
    Re: [PATCH 7/7] DWARF: add the config option Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-26 14:20 +0200

csiph-web