Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1648080
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Bluetooth: hci_ll: Fix download_firmware() return when __hci_cmd_sync fails |
| Date | 2017-05-23 15:50 +0200 |
| Message-ID | <tKime-3Tp-35@gated-at.bofh.it> (permalink) |
| References | <tJW2l-6oO-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 22, 2017 at 8:50 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> When __hci_cmd_sync() fails, download_firmware() should also fail, and
> the same error value should be returned as PTR_ERR(skb).
>
> Without this fix, download_firmware() will return a success when it actually
> failed in __hci_cmd_sync().
>
> Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support")
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
> drivers/bluetooth/hci_ll.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Bluetooth: hci_ll: Fix download_firmware() return when __hci_cmd_sync fails Guodong Xu <guodong.xu@linaro.org> - 2017-05-22 16:00 +0200 Re: [PATCH] Bluetooth: hci_ll: Fix download_firmware() return when __hci_cmd_sync fails Rob Herring <robh@kernel.org> - 2017-05-23 15:50 +0200 Re: [PATCH] Bluetooth: hci_ll: Fix download_firmware() return when __hci_cmd_sync fails Marcel Holtmann <marcel@holtmann.org> - 2017-05-23 16:20 +0200
csiph-web