Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647992

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

Show all headers | View raw

On Tue, May 23, 2017 at 12:55 AM, zhangfei <zhangfei.gao@linaro.org> wrote:
> Hi, Rob
>
>
> Thanks for the review.
>
>
> On 2017年05月23日 08:39, Rob Herring wrote:
>>
>> On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote:
>>>
>>> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>>>
>>> Add I2C nodes for Hi3660-hikey960.
>>>
>>> On HiKey960,
>>> I2C0, I2C7 is connected to Low Speed Expansion Connector.
>>> I2C1 is connected to ADV7535.
>>> I2C3 is connected to USB5734.

[...]

>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>>> b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>>> index f55710a..f217c9d 100644
>>> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>>> @@ -186,6 +186,62 @@
>>>                         #reset-cells = <2>;
>>>                 };
>>>   +             i2c0: i2c@FFD71000 {
>>
>> lowercase hex please.
>
> Yes, will change
>>
>>
>>> +                       compatible = "snps,designware-i2c";
>>
>> These should have an SoC specific compatible.
>
> We directly use drivers/i2c/busses/i2c-designware-platdrv.c,
> do we still an soc specific compatible?

It's fine if the driver uses the snps compatible, but the dts should
still have an SoC specific one.

> Checked arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi, and other examples,
>
> compatible = "snps,designware-i2c" is used.

That was a mistake in the other platforms. We shouldn't continue repeating it.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Guodong Xu <guodong.xu@linaro.org> - 2017-05-17 10:40 +0200
  Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 02:40 +0200
    Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-23 08:00 +0200
      Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-23 08:40 +0200
        Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 14:50 +0200
      Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 14:50 +0200
        Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-24 04:40 +0200
          Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-05-24 10:40 +0200

csiph-web