Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

From	zhangfei <zhangfei.gao@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660
Date	2017-05-23 08:40 +0200
Message-ID	<tKbE5-7Qs-3@gated-at.bofh.it> (permalink)
References	<tI2EV-J3-5@gated-at.bofh.it> <tI2EV-J3-9@gated-at.bofh.it> <tK61I-4fZ-15@gated-at.bofh.it> <tKb1n-7nt-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017年05月23日 13:55, zhangfei wrote:
> Hi, Rob
>
>
> Thanks for the review.
>
> On 2017年05月23日 08:39, Rob Herring wrote:
>> On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote:
>>> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>>>
>>> Add I2C nodes for Hi3660-hikey960.
>>>
>>> On HiKey960,
>>> I2C0, I2C7 is connected to Low Speed Expansion Connector.
>>> I2C1 is connected to ADV7535.
>>> I2C3 is connected to USB5734.
>>>
>>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>>> ---
>>>   arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 18 ++++++++
>>>   arch/arm64/boot/dts/hisilicon/hi3660.dtsi         | 56 
>>> +++++++++++++++++++++++
>>>   2 files changed, 74 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts 
>>> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> index 64875a5..f685b1e 100644
>>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> @@ -29,6 +29,24 @@
>>>       };
>>>   };
>>>   +&i2c0 {
>>> +    status = "okay";
>>> +};
>>> +
>>> +&i2c1 {
>>> +    status = "okay";
>>> +
>>> +    adv7533: adv7533@39 {
>>> +        status = "ok";
>>> +        compatible = "adi,adv7533";
>>> +        reg = <0x39>;
>>> +    };
>>> +};
>>> +
>>> +&i2c7 {
>>> +    status = "okay";
>>> +};
>> labels for the LS connector?

Do you mean arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi

                 i2c@78ba000 {
                 /* On Low speed expansion */
                         label = "LS-I2C1";
                         status = "okay";
                 };

                 spi@78b7000 {
                 /* On High speed expansion */
                         label = "HS-SPI1";
                         status = "okay";
                 };

Thanks
>>
>>> +            compatible = "snps,designware-i2c";
>> These should have an SoC specific compatible.
> We directly use drivers/i2c/busses/i2c-designware-platdrv.c,
> do we still an soc specific compatible?
> Checked arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi, and other examples,
>
> compatible = "snps,designware-i2c" is used.
>
>
> Thanks
>

Thread

[PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Guodong Xu <guodong.xu@linaro.org> - 2017-05-17 10:40 +0200
  Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 02:40 +0200
    Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-23 08:00 +0200
      Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-23 08:40 +0200
        Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 14:50 +0200
      Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Rob Herring <robh@kernel.org> - 2017-05-23 14:50 +0200
        Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 zhangfei <zhangfei.gao@linaro.org> - 2017-05-24 04:40 +0200
          Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-05-24 10:40 +0200

csiph-web