Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices"

From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices"
Date	2017-05-23 10:40 +0200
Message-ID	<tKdwd-Fm-1@gated-at.bofh.it> (permalink)
References	(4 earlier) <tIWQO-7ue-9@gated-at.bofh.it> <tIX0u-7xL-3@gated-at.bofh.it> <tJ5r4-5g9-3@gated-at.bofh.it> <tJ9uF-8cg-9@gated-at.bofh.it> <tJgw9-4r3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On May 20 2017 or thereabouts, Dmitry Torokhov wrote:
> On Sat, May 20, 2017 at 11:59:50AM +0200, Benjamin Tissoires wrote:
> > Hi,
> > 
> > On May 20 2017 or thereabouts, Pascal Wichmann wrote:
> > > > Looks like you running your patched kernel?
> > > That's right.
> > > 
> > > 
> > > >>> CONFIG_RMI4_CORE=m
> > > >>> CONFIG_RMI4_I2C=m
> > > >>> CONFIG_RMI4_SPI=m
> > > >>> # CONFIG_RMI4_SMB is not set
> > > >
> > > > This is your issue I believe.
> > > 
> > > Indeed, enabling that configuration solves that issue.
> > > 
> > > However, I think it is quite unintuitive that a module (psmouse) chooses
> > > a default mode which requires another driver which is not necessarily
> > > included; though it would probably be not a very clean solution to
> > > explicitly check that as well.
> > > 
> > > Is this behaviour, that one module requires another without
> > > communicating that clearly, wanted?
> > > 
> > 
> > I can see 3 solutions:
> > 1. Have PS2_SMBUS depending on RMI_SMBUS (and ELAN_I2C, and others when
> >    required)
> > 2. Have PS2_SMBUS selecting RMI_SMBUS (and the others when time comes)
> > 3. Changing the default value of synaptics_intertouch to
> >    SYNAPTICS_INTERTOUCH_OFF when RMI_SMBUS is not set
> > 
> > Solution 3. might be interesting because it doesn't prevent users to
> > compile the module on the side and is Synaptics only.
> > 
> > Dmitry, any comments?
> 
> I like #3. We might also want to stick a warning into synaptics.c when
> we see a device that has intertouch, but RMI_SMBUS is disabled, so we
> could nudge users to switch over to RMI.
> 

OK, thanks. See the following series that should have all of this.

Cheers,
Benjamin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Pascal Wichmann <pascal.wichmann@pa-w.de> - 2017-05-19 21:00 +0200
  Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-19 21:10 +0200
    Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Pascal Wichmann <pascal.wichmann@pa-w.de> - 2017-05-19 21:40 +0200
      Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-19 22:30 +0200
        Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-19 22:50 +0200
          Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Pascal Wichmann <pascal.wichmann@pa-w.de> - 2017-05-20 07:50 +0200
            Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-20 12:10 +0200
              Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-20 19:40 +0200
                Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not  recognized anymore; commit e839ffa: "Input: synaptics - add support for  Intertouch devices" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-23 10:40 +0200

csiph-web