[tip:sched/core] ACPI: Adjust system_state check

From	tip-bot for Thomas Gleixner <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:sched/core] ACPI: Adjust system_state check
Date	2017-05-23 11:00 +0200
Message-ID	<tKdPz-N6-1@gated-at.bofh.it> (permalink)
References	<tHPRo-M2-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  9762b33dc31c67e34b36ba4e787e64084b3136ff
Gitweb:     http://git.kernel.org/tip/9762b33dc31c67e34b36ba4e787e64084b3136ff
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 16 May 2017 20:42:38 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 May 2017 10:01:36 +0200

ACPI: Adjust system_state check

To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

Make the decision whether a pci root is hotplugged depend on SYSTEM_RUNNING
instead of !SYSTEM_BOOTING. It makes no sense to cover states greater than
SYSTEM_RUNNING as there are not hotplug events on reboot and poweroff.

Tested-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/20170516184735.446455652@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 drivers/acpi/pci_root.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 919be0a..2405442 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -523,7 +523,7 @@ static int acpi_pci_root_add(struct acpi_device *device,
 	struct acpi_pci_root *root;
 	acpi_handle handle = device->handle;
 	int no_aspm = 0;
-	bool hotadd = system_state != SYSTEM_BOOTING;
+	bool hotadd = system_state == SYSTEM_RUNNING;
 
 	root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
 	if (!root)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch V2 07/17] ACPI: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-16 21:00 +0200
  Re: [patch V2 07/17] ACPI: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-16 21:10 +0200
  [tip:sched/core] ACPI: Adjust system_state check tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-05-23 11:00 +0200

csiph-web