[patch V2 07/17] ACPI: Adjust system_state check

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	[patch V2 07/17] ACPI: Adjust system_state check
Date	2017-05-16 21:00 +0200
Message-ID	<tHPRo-M2-31@gated-at.bofh.it> (permalink)
References	<tHPRn-M2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

Make the decision whether a pci root is hotplugged depend on SYSTEM_RUNNING
instead of !SYSTEM_BOOTING. It makes no sense to cover states greater than
SYSTEM_RUNNING as there are not hotplug events on reboot and poweroff.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
---
 drivers/acpi/pci_root.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -523,7 +523,7 @@ static int acpi_pci_root_add(struct acpi
 	struct acpi_pci_root *root;
 	acpi_handle handle = device->handle;
 	int no_aspm = 0;
-	bool hotadd = system_state != SYSTEM_BOOTING;
+	bool hotadd = system_state == SYSTEM_RUNNING;

 	root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
 	if (!root)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch V2 07/17] ACPI: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-16 21:00 +0200
  Re: [patch V2 07/17] ACPI: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-16 21:10 +0200
  [tip:sched/core] ACPI: Adjust system_state check tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-05-23 11:00 +0200

csiph-web