Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650327
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC |
| Date | 2017-05-25 10:50 +0200 |
| Message-ID | <tKWCZ-5Vo-5@gated-at.bofh.it> (permalink) |
| References | <tKCuC-1DS-17@gated-at.bofh.it> <tKCuC-1DS-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Allwinner V3s SoC features a set of pins that have functionality of RGB
> LCD, the pins are at different pin ban than other SoCs.
>
> Add pinctrl node for them.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 3a06dc5b3746..81e5406661b4 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -297,6 +297,15 @@
> function = "i2c0";
> };
>
> + lcd_rgb666_pins: lcd_rgb666 {
Please don't use underscores in the node name. Also, Please end the name
with -pins. The node name should at least have that to indicate what it is.
ChenYu
> + pins = "PE0", "PE1", "PE2", "PE3", "PE4",
> + "PE5", "PE6", "PE7", "PE8", "PE9",
> + "PE10", "PE11", "PE12", "PE13", "PE14",
> + "PE15", "PE16", "PE17", "PE18", "PE19",
> + "PE23", "PE24";
> + function = "lcd";
> + };
> +
> uart0_pins_a: uart0@0 {
> pins = "PB8", "PB9";
> function = "uart0";
> --
> 2.12.2
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-05-24 13:20 +0200 Re: [linux-sunxi] [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Chen-Yu Tsai <wens@csie.org> - 2017-05-25 10:50 +0200
csiph-web