RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver

From	"Keiji Hayashibara" <hayashibara.keiji@socionext.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver
Date	2017-05-25 10:50 +0200
Message-ID	<tKWCZ-5Vo-3@gated-at.bofh.it> (permalink)
References	<tKyhk-79n-7@gated-at.bofh.it> <tKyhk-79n-17@gated-at.bofh.it> <tKTYu-4c9-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Yamada-san,

> > a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > new file mode 100644
> > index 0000000..a59d1ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > @@ -0,0 +1,20 @@
> > +UniPhier watchdog timer controller
> > +
> > +This UniPhier watchdog timer controller must be under sysctrl compatible
> > node.
> > +
> > +Required properties:
> > +- compatible: should be "socionext,uniphier-wdt"
> > +
> > +Example:
> > +
> > +	sysctrl@61840000 {
> > +		compatible = "socionext,uniphier-ld11-sysctrl",
> > +			     "simple-mfd", "syscon";
> > +		reg = <0x61840000 0x4000>;
> > +
> > +		sys_wdt: watchdog {
> > +			compatible = "socionext,uniphier-wdt";
> > +		}
> > +
> > +		other nodes ...
> > +	};
> 
> 
> Next time, please include
> devicetree@vger.kernel.org
> (and Rob) in your CC list for binding review.
> 
> I think scripts/get_maintainer.pl will do it correctly for you.
> 

OK. I will include to CC list in next v2 patch.

> 
> 
> > +#include <linux/delay.h>
> 
> Is this used?

It is unnecessary. I will remove it.

Thanks.

-----
Best Regards,
Keiji Hayashibara

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] add UniPhier watchdog support Keiji Hayashibara <hayashibara.keiji@socionext.com> - 2017-05-24 08:50 +0200
  [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver Keiji Hayashibara <hayashibara.keiji@socionext.com> - 2017-05-24 08:50 +0200
    Re: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver Guenter Roeck <linux@roeck-us.net> - 2017-05-24 15:50 +0200
      RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver "Keiji Hayashibara" <hayashibara.keiji@socionext.com> - 2017-05-25 10:40 +0200
    RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver <yamada.masahiro@socionext.com> - 2017-05-25 08:00 +0200
      RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver "Keiji Hayashibara" <hayashibara.keiji@socionext.com> - 2017-05-25 10:50 +0200

csiph-web