Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650242

Re: [PATCH 0/6] refine and rename slub sysfs

Show all headers | View raw

On Wed 24-05-17 23:21:24, Wei Yang wrote:
> On Wed, May 24, 2017 at 02:03:18PM +0200, Michal Hocko wrote:
> >On Wed 24-05-17 17:54:50, Wei Yang wrote:
> >> On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote:
> >[...]
> >> >Is this worth risking breakage of the userspace which consume this data
> >> >now? Do you have any user space code which will greatly benefit from the
> >> >new data and which couldn't do the same with the current format/output?
> >> >
> >> >If yes this all should be in the changelog.
> >> 
> >> The answer is no.
> >> 
> >> I have the same concern as yours. So this patch set could be divided into two
> >> parts: 1. add some new entry with current name convention, 2. change the name
> >> convention.
> >
> >Who is going to use those new entries and for what purpose? Why do we
> >want to expose even more details of the slab allocator to the userspace.
> >Is the missing information something fundamental that some user space
> >cannot work without it? Seriously these are essential questions you
> >should have answer for _before_ posting the patch and mention all those
> >reasons in the changelog.
> 
> It is me who wants to get more details of the slub behavior.  
> AFAIK, no one else is expecting this.

My point is that whatever the reason is, it _should_ be described
properly. This is a user visible change and we will have hard time to
change in future once there is userspace depending on it. So ask
yourself, is this so useful that the future maintenance will be still
reasonable? Also doesn't this export too much of the internal
implementation details that would make future development harder?
Also make sure to CC linux-api mailing list for future posts which
involve user API visible changes.

Thanks!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  [PATCH 1/6] mm/slub: add total_objects_partial sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
    Re: [PATCH 1/6] mm/slub: add total_objects_partial sysfs Christoph Lameter <cl@linux.com> - 2017-05-17 17:00 +0200
  [PATCH 3/6] mm/slub: add cpu_slabs_[total_]objects sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  [PATCH 6/6] mm/slub: rename cpu_partial_slab sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-17 17:00 +0200
  Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-18 11:10 +0200
    Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-23 05:30 +0200
      Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-23 08:40 +0200
        Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-23 18:10 +0200
        Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-24 12:00 +0200
          Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-24 14:10 +0200
            Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-24 17:30 +0200
              Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-24 18:10 +0200
              Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-25 09:00 +0200

csiph-web