Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1647599

Re: [PATCH 0/6] refine and rename slub sysfs

From Wei Yang <richard.weiyang@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 0/6] refine and rename slub sysfs
Date 2017-05-23 05:30 +0200
Message-ID <tK8Gd-60t-1@gated-at.bofh.it> (permalink)
References <tI7XX-48K-3@gated-at.bofh.it> <tIpBw-8eh-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote:
>On Wed 17-05-17 22:11:40, Wei Yang wrote:
>> This patch serial could be divided into two parts.
>> 
>> First three patches refine and adds slab sysfs.
>> Second three patches rename slab sysfs.
>> 
>> 1. Refine slab sysfs
>> 
>> There are four level slabs:
>> 
>>     CPU
>>     CPU_PARTIAL
>>     PARTIAL
>>     FULL
>> 
>> And in sysfs, it use show_slab_objects() and cpu_partial_slabs_show() to
>> reflect the statistics.
>> 
>> In patch 2, it splits some function in show_slab_objects() which makes sure
>> only cpu_partial_slabs_show() covers statistics for CPU_PARTIAL slabs.
>> 
>> After doing so, it would be more clear that show_slab_objects() has totally 9
>> statistic combinations for three level of slabs. Each slab has three cases
>> statistic.
>> 
>>     slabs
>>     objects
>>     total_objects
>> 
>> And when we look at current implementation, some of them are missing. So patch
>> 2 & 3 add them up.
>> 
>> 2. Rename sysfs
>> 
>> The slab statistics in sysfs are
>> 
>>     slabs
>>     objects
>>     total_objects
>>     cpu_slabs
>>     partial
>>     partial_objects
>>     cpu_partial_slabs
>> 
>> which is a little bit hard for users to understand. The second three patches
>> rename sysfs file in this pattern.
>> 
>>     xxx_slabs[[_total]_objects]
>> 
>> Finally it looks Like
>> 
>>     slabs
>>     slabs_objects
>>     slabs_total_objects
>>     cpu_slabs
>>     cpu_slabs_objects
>>     cpu_slabs_total_objects
>>     partial_slabs
>>     partial_slabs_objects
>>     partial_slabs_total_objects
>>     cpu_partial_slabs
>
>_Why_ do we need all this?

To have a clear statistics for each slab level.

>-- 
>Michal Hocko
>SUSE Labs

-- 
Wei Yang
Help you, Help me

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  [PATCH 1/6] mm/slub: add total_objects_partial sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
    Re: [PATCH 1/6] mm/slub: add total_objects_partial sysfs Christoph Lameter <cl@linux.com> - 2017-05-17 17:00 +0200
  [PATCH 3/6] mm/slub: add cpu_slabs_[total_]objects sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  [PATCH 6/6] mm/slub: rename cpu_partial_slab sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-17 16:20 +0200
  Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-17 17:00 +0200
  Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-18 11:10 +0200
    Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-23 05:30 +0200
      Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-23 08:40 +0200
        Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-23 18:10 +0200
        Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-24 12:00 +0200
          Re: [PATCH 0/6] refine and rename slub sysfs Michal Hocko <mhocko@kernel.org> - 2017-05-24 14:10 +0200
            Re: [PATCH 0/6] refine and rename slub sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-05-24 17:30 +0200
              Re: [PATCH 0/6] refine and rename slub sysfs Christoph Lameter <cl@linux.com> - 2017-05-24 18:10 +0200

csiph-web