Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning
Date	2017-05-25 07:40 +0200
Message-ID	<tKTF7-45C-11@gated-at.bofh.it> (permalink)
References	<tKxlf-6tH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 10:38:57PM -0700, Nick Desaulniers wrote:
> is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is
> only compiled in as a runtime check when CONFIG_DEBUG_VM is set,
> otherwise is checked at compile time and not actually compiled in.
> 
> Fixes the following warning, found with Clang:
> 
> mm/zsmalloc.c:472:12: warning: function 'is_first_page' is not needed and
> will not be emitted [-Wunneeded-internal-declaration]
> static int is_first_page(struct page *page)
>            ^
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-24 07:50 +0200
  Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-05-24 10:20 +0200
    Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 06:20 +0200
  Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Minchan Kim <minchan@kernel.org> - 2017-05-25 07:40 +0200

csiph-web