Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1649889

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error
Date 2017-05-24 21:40 +0200
Message-ID <tKKit-6rO-7@gated-at.bofh.it> (permalink)
References <tKgaK-2wv-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexander Potapenko <glider@google.com>
Date: Tue, 23 May 2017 13:20:28 +0200

> rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led
> to contents of |ifm| being uninitialized because nlh->nlmsglen was too
> small to accommodate |ifm|. The uninitialized data may affect some
> branches and result in unwanted effects, although kernel data doesn't
> seem to leak to the userspace directly.
> 
> The bug has been detected with KMSAN and syzkaller.
> 
> Signed-off-by: Alexander Potapenko <glider@google.com>

Applied, thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error Alexander Potapenko <glider@google.com> - 2017-05-23 13:30 +0200
  Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse  error Greg Rose <gvrose8192@gmail.com> - 2017-05-24 21:30 +0200
  Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse  error David Miller <davem@davemloft.net> - 2017-05-24 21:40 +0200
    Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error Alexander Potapenko <glider@google.com> - 2017-05-31 11:00 +0200
      Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse  error David Miller <davem@davemloft.net> - 2017-05-31 17:20 +0200
        Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error Alexander Potapenko <glider@google.com> - 2017-05-31 17:30 +0200

csiph-web