Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654022
| From | Alexander Potapenko <glider@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error |
| Date | 2017-05-31 11:00 +0200 |
| Message-ID | <tN7DY-2u7-17@gated-at.bofh.it> (permalink) |
| References | <tKgaK-2wv-9@gated-at.bofh.it> <tKKit-6rO-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi David, I've noticed that the upstream patch: https://github.com/torvalds/linux/commit/0ff50e83b5122e836ca492fefb11656b225ac29c contains the KMSAN report and the repro, despite I've put them under the triple dash (IIRC Eric told me I shouldn't bloat the patch descriptions with that information). Did I mess it up somehow? Alex On Wed, May 24, 2017 at 9:32 PM, David Miller <davem@davemloft.net> wrote: > From: Alexander Potapenko <glider@google.com> > Date: Tue, 23 May 2017 13:20:28 +0200 > >> rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led >> to contents of |ifm| being uninitialized because nlh->nlmsglen was too >> small to accommodate |ifm|. The uninitialized data may affect some >> branches and result in unwanted effects, although kernel data doesn't >> seem to leak to the userspace directly. >> >> The bug has been detected with KMSAN and syzkaller. >> >> Signed-off-by: Alexander Potapenko <glider@google.com> > > Applied, thanks. -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error Alexander Potapenko <glider@google.com> - 2017-05-31 11:00 +0200
Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error David Miller <davem@davemloft.net> - 2017-05-31 17:20 +0200
Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error Alexander Potapenko <glider@google.com> - 2017-05-31 17:30 +0200
csiph-web